Automatic setup/cleanup in Makefile. #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Automatically set up poetry environment when needed. Can still be explicitly run using `make setup`. - Added `make clean` to remove the poetry environment. - Added `make require`, run during setup, to check environment for the presence of python3/poetry, and the python3 version.
pappasam
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of setup items that I ran into while attempting to run
make formatfor #177. Since I ran into them by foolishly skipping past the README, I assume that others might as well and added the following checks.Automatically set up poetry environment when needed (e.g. for
make testormake format). Can still be explicitly run usingmake setup.Added
make cleanto remove the poetry environment.Added
make require, run during setup, to check environment for the presence of python3/poetry, and the python3 version. If any checks fail, show appropriate diagnostic messages.