Skip to content

Commit

Permalink
Merge pull request #239 from pappasam/default-disable-syntax-errors
Browse files Browse the repository at this point in the history
Default disable syntax errors
  • Loading branch information
pappasam authored Nov 18, 2022
2 parents 8f71df9 + cc5c984 commit 8416fcf
Show file tree
Hide file tree
Showing 5 changed files with 94 additions and 95 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 0.39.0

### Changed

- `jedi-language-server`-powered diagnostics are disabled by default. See: <https://github.com/pappasam/jedi-language-server/issues/187>

## 0.38.0

### Added
Expand Down
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ jedi-language-server aims to support Jedi's capabilities and expose them through

### Text Synchronization (for diagnostics)

**Note:** diagnostics are disabled by default because Jedi's syntax checking is not supported for new syntax in Python 3.10+. For a detailed discussion on this topic, please refer to [this issue](https://github.com/pappasam/jedi-language-server/issues/187).

- [textDocument/didChange](https://microsoft.github.io/language-server-protocol/specification#textDocument_didChange)
- [textDocument/didOpen](https://microsoft.github.io/language-server-protocol/specification#textDocument_didOpen)
- [textDocument/didSave](https://microsoft.github.io/language-server-protocol/specification#textDocument_didSave)
Expand Down Expand Up @@ -164,7 +166,7 @@ If you are configuring manually, jedi-language-server supports the following [in
"ignorePatterns": []
},
"diagnostics": {
"enable": true,
"enable": false,
"didOpen": true,
"didChange": true,
"didSave": true
Expand Down Expand Up @@ -203,9 +205,11 @@ If you are configuring manually, jedi-language-server supports the following [in

See coc-jedi's [configuration instructions](https://github.com/pappasam/coc-jedi#configuration) for an explanation of the above configurations.

## Additional Diagnostics
## Diagnostics

Jedi-powered diagnostics are disabled by default because Jedi's syntax checking is not supported for new syntax in Python 3.10+. For a detailed discussion on this topic, please refer to [this issue](https://github.com/pappasam/jedi-language-server/issues/187).

jedi-langugage-server provides diagnostics about syntax errors, powered by Jedi. If you would like additional diagnostics, we suggest using the powerful [diagnostic-language-server](https://github.com/iamcco/diagnostic-languageserver).
If you would like diagnostics (from [pylint](https://github.com/PyCQA/pylint), [mypy](https://github.com/python/mypy), etc.), we recommend using the powerful [diagnostic-language-server](https://github.com/iamcco/diagnostic-languageserver).

## Code Formatting

Expand Down
2 changes: 1 addition & 1 deletion jedi_language_server/initialization_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Completion(Model):


class Diagnostics(Model):
enable: bool = True
enable: bool = False
did_open: bool = True
did_save: bool = True
did_change: bool = True
Expand Down
Loading

0 comments on commit 8416fcf

Please sign in to comment.