Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to filter customers on the customers page by tags #815

Merged
merged 8 commits into from
May 10, 2021

Conversation

rhonsby
Copy link
Collaborator

@rhonsby rhonsby commented May 5, 2021

Description

This commit adds a new filter on the customer pages that allows users to filter by tags.

Issue

#807

Screenshots

CleanShot.2021-05-05.at.17.29.06.mp4

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

@rhonsby rhonsby requested a review from reichert621 May 5, 2021 21:31
@rhonsby
Copy link
Collaborator Author

rhonsby commented May 5, 2021

@reichert621 I put the filter below the search bar instead of next to it. It was a bit cramped when I had it between the search bar and the checkbox especially on smaller windows. lmk what you think.

@rhonsby rhonsby force-pushed the customer-filters branch from a044d9b to 90cbb0a Compare May 10, 2021 17:21
@rhonsby
Copy link
Collaborator Author

rhonsby commented May 10, 2021

@reichert621 added that test you asked for!

@reichert621 reichert621 merged commit a92b4c9 into master May 10, 2021
@reichert621 reichert621 deleted the customer-filters branch May 10, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants