Converts EditCustomerDetailsModal to a functional component using hooks #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good place to try out React Query as well. If I have time this weekend I'll make a PR showing how this component would look using these fetching hooks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @reichert621 suggested in #736,
EditCustomerDetailsModalwas a good opportunity to convert into a functional component using hooks especially since it didn't make use of any of the lifecycle methods.This commit does that and also splits the
toggleIsEditModalVisiblemethod into two separate methods to be more declarative.Screenshots
Edit + delete flow
CleanShot.2021-04-16.at.08.31.00.mp4
Default errors when fail to update + delete
CleanShot.2021-04-16.at.08.39.47.mp4
Using server errors when fail to update + delete
CleanShot.2021-04-16.at.08.39.11.mp4
Checklist
mix testmix format