Twilio integration v1 feature #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reichert621
force-pushed
the
twilio-integration-v1
branch
from
3d84567 to
8a76360
Compare
* Set up boilerplate for Twilio client * Add migration for twilio authorizations * Set up boilerplate UI for twilio authorization flow * Improve error handling * Add todos, fix warning * Hide todo comment
* Send SMS notification via twilio * Log error if twilio sms fails * Switch error to info * Remove unused from test
* Added logic * Added tests for context * Added controller tests * Pattern match param * Removed whitespace * Add inet6 back * Add typespec * Wrap test with describe * Moved find_or_create_customer_and_conversation to Conversations context * Mix format * Cleanup typespec * Log if twilio account is not found * Log warn message if twilio account is not found * Fix twilio controller test
reichert621
force-pushed
the
twilio-integration-v1
branch
from
8a76360 to
4806ab9
Compare
a8t
reviewed
Apr 2, 2021
lib/chat_api/twilio/notification.ex
Outdated
| Messages.Message | ||
| } | ||
|
|
||
| @spec notify_sms(ChatApi.Messages.Message.t()) :: {:error, any} | {:ok, Tesla.Env.t()} | ||
| def notify_sms(%Message{ | ||
| conversation_id: conversation_id, | ||
| body: body, | ||
| account_id: account_id, | ||
| customer: %Customer{phone: customer_phone} |
There was a problem hiding this comment.
just curious - looks like most of the refactor here was in order to move this into the with. Is that because we can't be sure that the customer is preloaded? @reichert621
There was a problem hiding this comment.
in this case, the message is coming from the agent/user, not the customer -- so customer here will be nil... we need to get the customer from the message's conversation instead :)
|
thanks for the help on this @a8t @fmterrorf! 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch for the Twilio integration v1: #678