Tests factories and ex machina #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reichert621
reviewed
Nov 13, 2020
|
looks reasonable so far @flmel! thanks :) |
…mel/papercups into tests_facories_and_ex_machina
|
looks great so far @flmel! it's quite long so it might take me some to review all of it 😅 but looking forward to merging your updates 🎉 |
the only issue would be is that it blocks further backend tasks since adding more tests would cause catch22 |
|
yup good point -- sorry about that! i'll make sure we prioritize this before merging any new backend tests 👍 |
reichert621
reviewed
Dec 7, 2020
There was a problem hiding this comment.
amazing work on this @flmel! 🚀 🚀 🚀
simplifies tests, and also speeds them up 😄 (i think it went from ~30s before to now around ~10s on my laptop!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
work in progress
Added ex_machina in order to DRY tests did rework the accounts tests
Issue
#316 and #60
Screenshots
For frontend updates, please include a screenshot.
Checklist
mix testmix format