Add new feature to count messages by date #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reichert621
requested changes
Oct 5, 2020
There was a problem hiding this comment.
looks great @WLSF! just one small request to give the methods slightly more descriptive names 😄
lib/chat_api/reporting.ex
Outdated
| @@ -31,6 +31,20 @@ defmodule ChatApi.Reporting do | |||
| |> Repo.all() | |||
| end | |||
|
|
|||
| def count_sent_messages() do | |||
There was a problem hiding this comment.
let's rename this to count_sent_messages_by_date, so that it's clearer what the output looks like :)
(otherwise it sounds like this method returns a number)
There was a problem hiding this comment.
hmm, makes sense! thanks!
lib/chat_api/reporting.ex
Outdated
| |> Repo.all() | ||
| end | ||
|
|
||
| def count_received_messages() do |
There was a problem hiding this comment.
same as above, let's just add _by_date to the end of this method's name to make it clear what's going on 👍
| %{date: ~D[2020-09-02], count: 1}, | ||
| %{date: ~D[2020-09-03], count: 1} | ||
| ] = Reporting.count_received_messages() | ||
| end |
reichert621
approved these changes
Oct 5, 2020
|
let me know if there are any other tickets you'd be interested in tackling @WLSF 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 2 new functions on
reporting.ex:Issue
#255
Screenshots
N/A updates on frontend
Checklist
mix testmix format