-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the module path to the definition name to avoid name collisions #373
Merged
tiagolobocastro
merged 10 commits into
paperclip-rs:master
from
TobiasDeBruijn:module_path_in_defintionm_name
Jan 28, 2022
Merged
Add the module path to the definition name to avoid name collisions #373
tiagolobocastro
merged 10 commits into
paperclip-rs:master
from
TobiasDeBruijn:module_path_in_defintionm_name
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes paperclip-rs#357, better alternative to paperclip-rs#358.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TobiasDeBruijn, as discussed previously this should be opt-in only - we can probably do that by hiding this behind a feature gate?
Looks good, can we add a test for this feature? |
I'll give writing a test a shot! |
Thanks @TobiasDeBruijn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix #357, but uses an alternative approach to #358.
With this PR, the behaviour will be as follows:
results in the following spec:
The advantage of this PR over #358 is that the generated spec is always the same for the same input code.
The name is determined by taking the output of
std::module_path!()
, removing the first 'component' (i.e. the crate name), then joining with_
as a separator.This will not break code backwards compatibility, but it will break spec backwards compatibility, i.e. the generated spec is different from how it would be without this PR