Simplify Events::Update by moving the timestamp-copying feature up the stack #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iiwo WDYT? |
jaredbeck
force-pushed
the
refactor_update_event
branch
from
54cdafb
to
5c5089a
Compare
.. to RecordTrail#build_version_on_update. This seems cleaner to me than the previous `delete(:created_at)` solution. This way, the feature lives in a single file, instead of two.
jaredbeck
force-pushed
the
refactor_update_event
branch
from
5c5089a
to
237bd9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, on a related note, forbid certain metadata keys, such as
created_at. The metadata feature is mainly intended for new columns. Hopefully no one is using these forbidden metadata keys, because that seems .. dangerous. More apropos to this PR, if we support such keys, then moving the timestamp-copying feature out ofEvents::Updatemight not be possible.