fix: do not store ignored and skipped attributes in object_changes on destroy
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbeck
approved these changes
Jan 2, 2019
| else | ||
| @record.changed | ||
| end | ||
| changes_in_latest_version.keys |
There was a problem hiding this comment.
This avoids duplicating the conditional? Nice!
|
|
||
| private | ||
|
|
||
| # Rails' implementation returns nothing on destroy :/ |
There was a problem hiding this comment.
Nice use of polymorphism!
When overriding methods in the future, please add a # @override comment, like this:
# Rails' implementation returns nothing on destroy :/
#
# @override
aried3r
pushed a commit
to aried3r/paper_trail
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think skipped and ignored attributes should be ignored in
object_changesondestroy(same way as oncreateandupdate). This PR fixes that.master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.