Raise helpful error when CVC is abstract #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm kind of surprised I was able to write a test for this. Ruby so crazy. Sure, define a class inside your expectation block. Do what you want! |
jaredbeck
force-pushed
the
abstract_cvc
branch
from
eb990e5
to
cc203a2
Compare
Instead of crashing when misconfigured Custom Version Classes are used, an error will be raised earlier, with a much more helpful message. [Fixes #961]
jaredbeck
force-pushed
the
abstract_cvc
branch
from
cc203a2
to
c5b4a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of crashing when misconfigured Custom Version Classes are used, an error will be raised earlier, with a much more helpful message.
[Fixes #961]