Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base class name for reification and add fractional second precision to test db #1028

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Use base class name for reification and add fractional second precision to test db #1028

merged 3 commits into from
Dec 21, 2017

Conversation

andre1810
Copy link
Contributor

  • Use base class name for reification of associations
  • Add explicit precision on datetime columns to enable fractional second precision on mysql

@jaredbeck jaredbeck self-requested a review December 21, 2017 22:26
@andre1810
Copy link
Contributor Author

@jaredbeck Sorry, I had to open this again due an mistake on editing the commits.

jaredbeck
jaredbeck reviewed Dec 21, 2017
View reviewed changes
spec/dummy_app/app/models/person.rb Outdated
belongs_to :vehicle, class_name: "Vehicle", foreign_key: :vehicle_id, optional: true
else
belongs_to :vehicle, class_name: "Vehicle", foreign_key: :vehicle_id
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this association (belongs_to :vehicle) is unused?

@jaredbeck
Copy link
Member

Sorry, I had to open this again due an mistake on editing the commits.

No worries, open as many PR as you feel like 😄 Also, check out git rebase --interactive, you might like it. It's pretty powerful (and dangerous).

@jaredbeck
Copy link
Member

OK, I'm ready to merge this. Anything else you want to do?

@andre1810
Copy link
Contributor Author

andre1810 commented Dec 21, 2017 •
edited
Loading

No, I´m done. Thank you 👍
@jaredbeck Do you have a date for the next release?

@jaredbeck jaredbeck merged commit aaf11dd into paper-trail-gem:master Dec 21, 2017
@jaredbeck
Copy link
Member

No, I'm done. Thank you 👍

Thank you! Nice work.

Do you have a date for the next release?

The next release from the master branch will probably be in April.

Please backport this by opening a PR against the 8-stable branch, and I can do an 8.2.0 release this weekend.

@andre1810 andre1810 deleted the issue_594_base_class branch December 21, 2017 23:06
jaredbeck added a commit that referenced this pull request Dec 22, 2017
@jaredbeck
Merge pull request #1030 from andre1810/8-issue_594
4a8d320 
Backport #1028: Use base class name for reification and add fractional second precision to test db
@jaredbeck
Copy link
Member

Released as 8.1.2

(I know I said 8.2.0, but I changed my mind; it's really more of a fix than an addition)

@jaredbeck jaredbeck mentioned this pull request Dec 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredbeck jaredbeck jaredbeck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre1810 @jaredbeck