Skip to content

Commit

Permalink
close #392; Update README instructions to include instructions for ho…
Browse files Browse the repository at this point in the history 
…w to use a custom initializer and prevent breakage of the Rails::Engine functionality [ci skip]
  • Loading branch information
@batter
batter committed Jul 8, 2014
1 parent 44dcdba commit b9b0d17
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,10 @@ For example:

```ruby
# config/initializers/paper_trail.rb

# the following line is required for PaperTrail >= 3.0.3 with Rails
PaperTrail::Rails::Engine.eager_load!

module PaperTrail
class Version < ActiveRecord::Base
attr_accessible :author_id, :word_count, :answer
Expand Down

2 comments on commit b9b0d17

@dan-palmer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement for PaperTrail::Rails::Engine.eager_load! to be added >= 3.0.3 on a minor change seems a little peculiar when a lot of folk are going to allow pessimistic version constraints("~>") in their Gemfiles & this change will cause some issues if you use a custom versions class for your PaperTrails.

@batter
Copy link
Collaborator Author

@batter batter commented on b9b0d17 Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I did not realize this would be a necessary by-product of merging #347, however, the only other option beyond the CHANGELOG warning is to yank the 3.0.3 release on RubyGems, comment that part out of the gem for now, release a 3.0.4, and then cherry-pick it back in to the upcoming 3.1.0 release..

Please sign in to comment.