Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General maintenance and npm package updates (please see mentioned details) #7

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

paras20xx
Copy link
Contributor

@paras20xx paras20xx commented Jan 19, 2024

As described in papandreou/express-processimage#202 (comment) , we would prefer to keep various package versions consistent between impro and express-processimage. This PR does the corresponding updates. This is still a single PR with multiple individual commits. It can be split into separate multiple if required.

Relevant changes:

  • Now using Node.js 18 via .nvmrc
  • GitHub workflows: Dropped support for Node 14 and 16; Using Node 18 by default; Added support for Node 20

Refactoring:

  • Updated one of the image files in testdata/ directory, according to the npm package updates

Notes:

  • The local tests are passing
  • Not included in this PR - Updating exif-reader required some changes in the testdata where I'm not sure of the correctness of data whether old contents in testdata were correct or the new response via exif-reader (Relevant commit: paras20xx@2810a4f)

Kindly have a look @alexjeffburke @papandreou

@coveralls
Copy link

Coverage Status

coverage: 93.191%. remained the same
when pulling 1be01ef on paras20xx:master
into 768962e on papandreou:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants