Upgrade hijackresponse to version 4.0.0 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ hijackresponse (^3.0.0 → ^4.0.0) · Repo
Commits
See the full diff on Github. The new version differs by 29 commits:
4.0.0Remove warning on being untested on node 8 and aboveTest on node 6, 8 and 10Merge branch 'rewriteTests'Cleanup tests and remove unused codeRemove the original tests using the mocksPort tests of destroy hijackedExtract test from main spec fileRewrite the tests that relied on poor mockingMake sure emit gets copied overMerge branch 'feature/eslint-prettier'add eslint ignore commentReformat code with prettierReplace standard with eslint and prettierTrim editorconfigReplace istanbul with nycRearrange test folderAdd warning on node.js version compatibilty to READMERemove dependency on lodashRemove node 4 compatibility (semver-major)Update unexpected to 11.1.1 (plus plugins)Upgrade mocha to 6.0.2Add .nvmrc file, use node 6.12.3Update author's emaildo not build with node 0.12 on travisRevert "fix return value from hijackedRes.write (fixes #14)"update compression to 1.7.0fix return value from hijackedRes.write (fixes #14)update standard to 7.1.2 (newer releases has some new rules I don't want to fix right now)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands