Browsersync second round #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmukuthu
reviewed
Jan 12, 2017
| expect.use(require('unexpected-http')) | ||
| .use(require('unexpected-image')) | ||
| .use(require('unexpected-resemble')) | ||
| .use(require('unexpected-sinon')) | ||
| .use(require('magicpen-prism')) | ||
| .addAssertion('<string> to respond with <object|number>', function (expect, subject, value) { | ||
| var modifiedSubject = subject.replace(' ', ' http://localhost:9999'); | ||
| .addAssertion('<string|object> to respond with <object|number>', function (expect, subject, value) { |
There was a problem hiding this comment.
This would read or document itself better if it was a middle-of-the-rocket assertion, something like expect('GET /foo', 'prepended with hostname', 'to yield response', 200)
There was a problem hiding this comment.
I agree that it's a bit weird.
I think I would actually prefer to use the vanilla to yield response satisfying assertion (unexpected-http) and just put http://localhost:${serverPort} into the url in each test. That would make it easier to realize that those tests connect to a "real" server instance.
There was a problem hiding this comment.
I'll make that change
|
@papandreou @joelmukuthu How about now? |
|
Released in v7.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res.statusneeds to be polyfilled for browser-sync support