Add explicit path to authorization/index.js to fix imports within Jest environments #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 98 97 -1
Lines 2438 2437 -1
=====================================
- Hits 2438 2437 -1
Continue to review full report at Codecov.
|
|
Could you please point me to the relevant jest issue? I don't understand why this is necessary. |
|
I'm not aware of a Jest issue associated with this behavior. I'm also not sure if this is the expected behavior of the default Jest resolver. Possibly related: |
|
my OCD for uniform code style can't stand this change :) How about what i just pushed, does that solve the jest issue for you? |
…olver. See https://github.com/jsonnull/jest-directory-named-resolver for a custom Jest resolver that also fixes the issue.
panva
force-pushed
the
fix/jest-resolver-compatibility
branch
from
1798c2b
to
8ea9e2c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring
node-oidc-providerin Jest 20+ fails because /lib/actions/authorization/index.js does not resolve correctly.This change fixes the issue with the Jest 20+ resolver. See https://github.com/jsonnull/jest-directory-named-resolver for a custom Jest resolver that also addresses the issue.
All tests pass.