Added group creation option and corresponding documentation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtarro
commented
Feb 10, 2022
| # Add groups if SSH_GROUPS=group:gid set | ||
| if [ -n "${SSH_GROUPS}" ]; then | ||
| USERS=$(echo $SSH_USERS | tr "," "\n") | ||
| GROUPZ=$(echo $SSH_GROUPS | tr "," "\n") |
There was a problem hiding this comment.
It took me quite a long time to discover that the natural name for this variable, GROUPS, is a reserved keyword in bash, and assigning to it silently kills the script!
macropin
reviewed
May 31, 2023
macropin
requested changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new config option
SSH_GROUPS, which is a list of groups and GIDs to create. These groups will be created before the users are created (assumingSSH_USERSis also specified). Specifying this option disables automatic group creation of user-named groups if you also specifySSH_USERSsince it's assumed you want greater control in this case.My use case is such that my users are all members of one group, so this lets me create the group first, then create the users and set their GIDs to the group I just created.