-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype inclusion of release notes in docs #184
base: main
Are you sure you want to change the base?
Conversation
* Treat them as a top level "type" of doc * Sidebar sorting is finicky :-/ * Some friction around when we write the notes versus switch the 'current' doc version ref pantsbuild#89
Have not used docusaurus before, not sure if this is on the right track. |
The idea sounds good! Just brainstorming:
|
It seems to be good enough for various prominent Python projects so I decided I was okay with it: But yeah it does feel slightly wonky. I think evergreen is reasonable, but that makes the syncing inconsistent which might be it's own form of wonkyness?
I think that's reasonable from an avoiding syncing wonkyness perspective but I'm struggling to visualize a project website that does it that way. It's usually a list. |
I think it just being an evergreen page (akin to, and maybe linked from) the versions page is fine. We can either special case the syncing, or just keep them in this repo and update them here if that's too weird |
…20847) As far as I can tell the release notes (formerly `src/python/pants/notes`) are no longer included in wheel builds, so they can be considered more "normal" documentation. This moves them, and stops the classify-changes script from flagging them as a `release`-level change; they'll now just be `docs`. The pantsbuild.org sync_docs workflow copies the `docs/docs` directory, so won't be automatically including these... but maybe pantsbuild/pantsbuild.org#184 will change this (that PR needs changes, after this).
'current' doc version
ref #89