Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace front-page "learn more" link with hard-coded 2.19 one #171

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Mar 8, 2024

This papers over the dead "Learn more" link on the pantsbuild.org front page (pantsbuild/pants#20648) by replacing it with the hard-coded /2.19/docs/introduction/welcome-to-pants, for the current latest-stable version.

This isn't a full solution: preferably this would be a "dynamic" link, pointing to the latest stable version. Thus this doesn't close that issue.

The dynamic approach we take in some other pages isn't perfect because it isn't to the latest stable release, but can include pre-releases (it currently points to /2.20/..., which is probably reasonable for a contributing guide, but less so for a "getting started" one):

We try and make contributions easy. For example, you can suggest documentation fixes by clicking on the Suggest Edits link on any page. And you can report bugs by opening a [GitHub issue](https://github.com/pantsbuild/pants/issues). If you want to hack on the Pants codebase itself there is a <Link to={`/${versions[0]}/docs/contributions`}>helpful guide</Link>.

@huonw huonw changed the title Replace front-page learn-more link with hard-coded 2.19 one Replace front-page "learn more" link with hard-coded 2.19 one Mar 8, 2024
@huonw huonw requested review from benjyw and thejcannon March 8, 2024 06:28
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to stop the bleeding, but yeah, we should figure out a "latest stable version" thing for these. Thanks!

@huonw huonw merged commit f6bbebe into pantsbuild:main Mar 8, 2024
1 check passed
@huonw huonw deleted the huonw/learn-more branch March 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants