Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize CI lint shard timing out #9155

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

Eric-Arellano
Copy link
Contributor

Now that we're using both V2 isort and docformatter, we've seen most CI runs time out for the lint shard. This is because we do not cache the V2 results and the V2 linters have atrocious performance when the cache is cold, per https://docs.google.com/document/d/1Tdof6jx9aVaOGeIQeI9Gn-8x7nd6LfjnJ0QrbLFBbgc/edit#.

A followup could use remote execution with the lint shard.

Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I was hitting this in a PR and was assuming it was my fault. If this doesn't consistently solve it would be wonderful to revert the docformatter use until it can be made performant. Master and all PRs are effectively red otherwise.

@jsirois jsirois mentioned this pull request Feb 20, 2020
@Eric-Arellano
Copy link
Contributor Author

I was hitting this in a PR and was assuming it was my fault.

Me too.

If this doesn't consistently solve it would be wonderful to revert the docformatter use until it can be made performant.

I think I'll pursue remote caching later today, as V2 linter caching is no longer my #1 priority so we won't get a more sustainable fix for the performance quite yet.

@Eric-Arellano Eric-Arellano merged commit 9a18727 into pantsbuild:master Feb 20, 2020
@Eric-Arellano Eric-Arellano deleted the fix-lint branch February 20, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants