Upgrade docformatter to 1.7.0 to support Python 3.13
#21526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnan-chandra
added
category:internal
krishnan-chandra
force-pushed
the
upgrade-docformatter-latest
branch
2 times, most recently
from
50ffdd5 to
66667a1
Compare
krishnan-chandra
force-pushed
the
upgrade-docformatter-latest
branch
from
66667a1 to
350f036
Compare
krishnan-chandra
changed the title
docformatter to the latest versiondocformatter to 1.7.0 to support Python 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
docformatterin the Pants codebase does not support Python 3.13, due to the use of the lib2to3 module which was removed. The most recent release ofdocformatterwas in July 2023, and it's the release that is used here.Related Slack discussion: https://pantsbuild.slack.com/archives/C046T6T9U/p1728393944035549?thread_ts=1728386679.902609&cid=C046T6T9U
Process
This PR is specifically split out into 3 steps/commits:
.git-blame-ignore-revswith the new changes from step 2Important
If merging, this PR should be merged via rebase-and-merge rather than squash-and-merge so that the changes to
git-blame-ignore-revsremain intact.