Remove deprecated pex_binary(platforms=...) for 2.22, deprecate resolve_local_platforms
#20823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
force-pushed
the
huonw/rm-pex-platforms
branch
from
9eaed5a to
cd0764f
Compare
huonw
changed the title
resolve_local_platformspex_binary(platforms=...) for 2.22, deprecate resolve_local_platforms
benjyw
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was deprecated in #20012, released in 2.19. We've now branched for 2.21 and thus
mainis prepping for 2.22. So, the deprecation has expired!In that PR, there was discussion about working out whether this should remain for longer. This has been deprecated for several releases now, and it's being removed early in the 2.22 release cycle: if someone comments, we can reinstate/reconsider.
Also, as part of this, I noticed the
resolve_local_platformsfield and option now seem to be meaningless: the underlyingpex --resolve-local-platformsfield is documented asWhen --platforms are specified, .... Thus, this deprecates that field and the global option for 2.24.