Fix formatting of the "pex.platforms is deprecated" message #20514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkerPants
pushed a commit
that referenced
this pull request
Feb 12, 2024
Fixes a missing f-string formatter for the `pex_binary`'s `platforms`
field
Before:
> 16:02:15.59 [WARN] DEPRECATED: the platforms field is scheduled to be
removed in version 2.22.0.dev0.
Using the `platforms` field in the target
src/python/something_something:pex-executable. The platforms field is a
hack. The abbreviated information it provides is sometimes insufficient,
leading to hard-to-debug build issues. Use complete_platforms instead.
See {doc_url('pex')} for details.
After:
> 16:03:43.09 [WARN] DEPRECATED: the platforms field is scheduled to be
removed in version 2.22.0.dev0.
Using the `platforms` field in the target
src/python/something_something:pex-executable. The platforms field is a
hack. The abbreviated information it provides is sometimes insufficient,
leading to hard-to-debug build issues. Use complete_platforms instead.
See https://www.pantsbuild.org/v2.20/docs/pex for details.
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.19.xSuccessfully opened #20527. Thanks again for your contributions! |
huonw
pushed a commit
that referenced
this pull request
Feb 13, 2024
…ick of #20514) (#20527) Fixes a missing f-string formatter for the `pex_binary`'s `platforms` field Before: > 16:02:15.59 [WARN] DEPRECATED: the platforms field is scheduled to be removed in version 2.22.0.dev0. Using the `platforms` field in the target src/python/something_something:pex-executable. The platforms field is a hack. The abbreviated information it provides is sometimes insufficient, leading to hard-to-debug build issues. Use complete_platforms instead. See {doc_url('pex')} for details. After: > 16:03:43.09 [WARN] DEPRECATED: the platforms field is scheduled to be removed in version 2.22.0.dev0. Using the `platforms` field in the target src/python/something_something:pex-executable. The platforms field is a hack. The abbreviated information it provides is sometimes insufficient, leading to hard-to-debug build issues. Use complete_platforms instead. See https://www.pantsbuild.org/v2.20/docs/pex for details. Co-authored-by: Dimitar Kovachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a missing f-string formatter for the
pex_binary'splatformsfieldBefore:
After: