Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare remote::remote_cache::CommandRunner for other providers #19459

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Jul 14, 2023

This does preparatory refactoring towards #11149, by adjusting remote::remote_cache::CommandRunner in a few ways to make it easier to plop in new 'providers':

  • package the various options for creating a provider/command runner into structs, and a bunch of mechanical refactoring to use those structs
  • explicit tests for the REAPI provider

This continues #19424, but, unlike that one, doesn't refactor remote_cache_tests.rs to (mostly) use in-memory providers, as those tests are significantly more complicated, with many more services than just the get/update caching provider and I don't think it strictly blocks #11149.

After this, the next steps towards #11149 will be:

  1. implement new providers, with some sort of factory function for constructing the appropriate provider
  2. expose settings in pants.toml to select and configure those new providers

@huonw huonw added the category:internal CI, fixes for not-yet-released features, etc. label Jul 14, 2023
@huonw huonw marked this pull request as ready for review July 14, 2023 02:52
@huonw huonw requested review from stuhood and thejcannon July 14, 2023 02:53
@huonw huonw merged commit 237d7ab into pantsbuild:main Jul 19, 2023
@huonw huonw deleted the feature/11149-action-cache-provider-prep branch July 19, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants