Allow for run --debug-adapter to match breakpoints when source is running in a sandbox
#17566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @rhinck |
|
Another flavor of this solution incoming. Hold tight |
thejcannon
force-pushed
the
debugging-run
branch
from
e5a2b5c to
066008a
Compare
|
OK the new way doesn't require any additional action from the user |
kaos
approved these changes
Nov 17, 2022
|
Thanks! Does this need cherry-picking anywhere? |
|
Oh yeah good point. As far back as makes sense |
thejcannon
added a commit
to thejcannon/pants
that referenced
this pull request
Nov 18, 2022
…unning in a sandbox (pantsbuild#17566) Fixes pantsbuild#17540 The key is that the DAP client is sending `pathMappings`, which normally sets `remoteRoot` to `"."` which for `run` isn't true. There's no easy way to have the server set it's own mapping so we monkeypatch.
thejcannon
added a commit
to thejcannon/pants
that referenced
this pull request
Nov 18, 2022
…unning in a sandbox (pantsbuild#17566) Fixes pantsbuild#17540 The key is that the DAP client is sending `pathMappings`, which normally sets `remoteRoot` to `"."` which for `run` isn't true. There's no easy way to have the server set it's own mapping so we monkeypatch.
thejcannon
added a commit
to thejcannon/pants
that referenced
this pull request
Nov 18, 2022
…unning in a sandbox (pantsbuild#17566) Fixes pantsbuild#17540 The key is that the DAP client is sending `pathMappings`, which normally sets `remoteRoot` to `"."` which for `run` isn't true. There's no easy way to have the server set it's own mapping so we monkeypatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17540
The key is that the DAP client is sending
pathMappings, which normally setsremoteRootto"."which forrunisn't true.There's no easy way to have the server set it's own mapping so we monkeypatch.