[CMS-459] Add php 8.1 support #2295

jabxjab · 2021-12-19T11:01:32Z

No description provided.

…cated"

… be compatible with YYY..."

…uilt-in functions is deprecated"

…tests manually)

… either be compatible with YYY..." and suppress the deprecation instead by using "#[\ReturnTypeWillChange]"

greg-1-anderson · 2021-12-19T23:31:48Z

tests/config/bootstrap.php

@@ -63,7 +63,11 @@

 if (!getenv('TERMINUS_TESTING_RUNTIME_ENV')) {
    // Create a testing runtime multidev environment.
-    $sitename = TerminusTestTrait::getSiteName();
+    $sitename = (new class {


There must be a better way to refactor this helper so that we do not need to instantiate an anonymous class just to call the wrapper.

Maybe make a test util class with the useful static methods we need to call from bootstrap. Could move all of the statics from TerminusTestTrait there, optionally with wrappers in TerminusTestTrait, although perhaps this level of cleanup isn't worth the effort.

100% agree with this. I was not a fan of this TerminusTestTrait from the beginning.
Refactored TerminusTestTrait into TerminusTestBase.

greg-1-anderson · 2021-12-19T23:32:16Z

src/Request/RequestOperationResult.php

@@ -68,6 +68,7 @@ public function setStatusCodeReason(string $status_code_reason): void
     * @param mixed $offset
     * @return bool
     */
+    #[\ReturnTypeWillChange]


Glad to see we won't need separate implementations of this class.

greg-1-anderson

Converting from a trait to a base class is a good improvement.

uberhacker · 2021-12-24T20:49:33Z

Merge conflicts? Probably due to #2299.

…cated"

… be compatible with YYY..."

…uilt-in functions is deprecated"

…tests manually)

… either be compatible with YYY..." and suppress the deprecation instead by using "#[\ReturnTypeWillChange]"

greg-1-anderson · 2022-01-05T22:24:55Z

Updated dependencies and rebased with HEAD of 3.x.

…hp >= 8.1

greg-1-anderson · 2022-01-10T13:36:27Z

bin/terminus

 if (version_compare(PHP_VERSION, '7.4.0', '<') === true) {
    echo "\n";
    echo 'Sorry, your PHP version (' . PHP_VERSION . ') is no longer supported.' . "\n";
    echo 'Upgrade to PHP 7.4 or newer to use Terminus 3. For PHP versions prior to 7.4, downgrade to Terminus 2.x.'; echo "\n\n";
    exit(1);
-} elseif (version_compare(PHP_VERSION, '8.2.0', '>=') === true) {


We should always have some version of PHP that we don't support yet. Is it too early to say that 8.2 stable will run without issue on the next release of Terminus? If not, then let's at a minimum reject 8.3.0+

@greg-1-anderson Rolled-back to support active php 8.1 only

greg-1-anderson · 2022-01-10T13:36:56Z

bin/terminus

+
+if (version_compare(PHP_VERSION, '8.1.0', '>=') === true) {
+    // Prevent outputting PHP deprecation messages produced by vendors.
+    error_reporting(error_reporting() & ~E_DEPRECATED);


If the consolidation dependencies have been updated, then we might not need this any longer.

@greg-1-anderson Updated dependencies and tested for 8.1 - tests passed. Not needed for PHP 8.1 anymore, so removed.

greg-1-anderson · 2022-01-10T13:38:37Z

tests/Functional/TerminusTestBase.php

+    protected function assertCommandExists(string $commandName)
+    {
+        $commandList = $this->terminus('list');
+        $this->assertStringContainsString($commandName, $commandList);


Might this give a false positive? Maybe run help <commandName> and check for errors?

@greg-1-anderson Better to ask @kporras07 since this is a code merging change (getting rid of TerminusTestTrait and TerminusUtilsTrait)

jabxjab · 2022-01-11T07:50:26Z

bin/terminus

-} elseif (version_compare(PHP_VERSION, '8.1.0', '>=') === true) {
+}
+
+if (!getenv('TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP') && version_compare(PHP_VERSION, '8.2.0', '>=') === true) {


The check for getenv('TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP') needs to be at the top since any echo would bloat commands' responses.

greg-1-anderson

LGTM, thanks

CdrMarks · 2022-02-15T16:33:54Z

Fixes #2279

Sergei Churilo added 11 commits December 19, 2021 09:47

Add "schedule" event and "long" functional test suit CI workflow

2a02d8e

Add php 8.1 to CI functional testing matrix

3ca8c05

Add "--stop-on-failure" option to "test:short" composer script

375d35e

Fix php 8.1 deprecation "Calling a static element on a trait is depre…

04e13b5

…cated"

Fix php 8.1 deprecation "Deprecated: Return type of XXX should either…

c75758d

… be compatible with YYY..."

Fix php 8.1 deprecation "Passing null to non-nullable parameters of b…

e9f1362

…uilt-in functions is deprecated"

Fix use of CommandExecutorTrait in LocalMachineHelper

e9194c8

Add php 8.1 support

914a2e8

Add "workflow_dispatch" event to CI workflow (trigger all functional …

94b821f

…tests manually)

Update comment on error_reporting() set

d7306ae

Revert fix php 8.1 deprecation "Deprecated: Return type of XXX should…

63c9a17

… either be compatible with YYY..." and suppress the deprecation instead by using "#[\ReturnTypeWillChange]"

jabxjab requested a review from a team December 19, 2021 11:01

greg-1-anderson reviewed Dec 19, 2021

View reviewed changes

Refactor TerminusTestTrait into TerminusTestBase

abfcf04

jabxjab force-pushed the feature/cms-459 branch from c5020e5 to abfcf04 Compare December 20, 2021 12:09

jabxjab requested a review from greg-1-anderson December 20, 2021 12:36

greg-1-anderson approved these changes Dec 20, 2021

View reviewed changes

greg-1-anderson force-pushed the feature/cms-459 branch from abfcf04 to 21f661a Compare January 5, 2022 22:18

Sergei Churilo added 10 commits January 5, 2022 14:21

Add "schedule" event and "long" functional test suit CI workflow

302aae1

Add php 8.1 to CI functional testing matrix

dbf5ef4

Add "--stop-on-failure" option to "test:short" composer script

98d7327

Fix php 8.1 deprecation "Calling a static element on a trait is depre…

01f2a12

…cated"

Fix php 8.1 deprecation "Deprecated: Return type of XXX should either…

380d9e3

… be compatible with YYY..."

Fix php 8.1 deprecation "Passing null to non-nullable parameters of b…

05d6463

…uilt-in functions is deprecated"

Fix use of CommandExecutorTrait in LocalMachineHelper

3742551

Add php 8.1 support

fad1511

Add "workflow_dispatch" event to CI workflow (trigger all functional …

2b70216

…tests manually)

Update comment on error_reporting() set

9eec8d7

Sergei Churilo and others added 4 commits January 5, 2022 14:21

Revert fix php 8.1 deprecation "Deprecated: Return type of XXX should…

7f2500e

… either be compatible with YYY..." and suppress the deprecation instead by using "#[\ReturnTypeWillChange]"

Refactor TerminusTestTrait into TerminusTestBase

584d632

Update dependencies

13b1b50

Incompatible PHP version is now 8.2+

cad15c4

greg-1-anderson force-pushed the feature/cms-459 branch from 21f661a to cad15c4 Compare January 5, 2022 22:23

Sergei Churilo added 5 commits January 10, 2022 14:23

Move TerminusUtilsTrait methods into TerminusTestBase

c887507

Prevent outputting PHP deprecation messages produced by vendors for p…

f3f496d

…hp >= 8.1

Remove error_reporting() from Request::request()

44ba68c

Remove php 8.0 and add php 8.2 to CI functional testing matrix

0d032db

Set nightly CI to run on 6:00 UTC (closer to midnight time for EST/PDT)

6d55a58

jabxjab changed the title ~~[CMS-459] Add php 8.1 support~~ [CMS-459] Add php 8.1 and php 8.2-dev support Jan 10, 2022

Sergei Churilo added 2 commits January 10, 2022 15:25

Set PHP error_reporting level regardless of PHP version

4996a65

Suppress PHP deprecation messages in RoboFile

ac0a151

jabxjab requested a review from greg-1-anderson January 10, 2022 13:01

greg-1-anderson reviewed Jan 10, 2022

View reviewed changes

Sergei Churilo added 2 commits January 11, 2022 10:21

Revert all error_reporting()

e32e935

Remove php 8.2 from functional testing matrix

6d54686

jabxjab changed the title ~~[CMS-459] Add php 8.1 and php 8.2-dev support~~ [CMS-459] Add php 8.1 support Jan 11, 2022

jabxjab commented Jan 11, 2022

View reviewed changes

jabxjab requested a review from greg-1-anderson January 11, 2022 10:56

greg-1-anderson approved these changes Jan 11, 2022

View reviewed changes

jabxjab merged commit 52bfa09 into 3.x Jan 11, 2022

jabxjab deleted the feature/cms-459 branch January 11, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CMS-459] Add php 8.1 support #2295

[CMS-459] Add php 8.1 support #2295

jabxjab commented Dec 19, 2021

greg-1-anderson Dec 19, 2021

jabxjab Dec 20, 2021

greg-1-anderson Dec 19, 2021

greg-1-anderson left a comment

uberhacker commented Dec 24, 2021

greg-1-anderson commented Jan 5, 2022

greg-1-anderson Jan 10, 2022

jabxjab Jan 11, 2022

greg-1-anderson Jan 10, 2022

jabxjab Jan 11, 2022

greg-1-anderson Jan 10, 2022

jabxjab Jan 11, 2022

jabxjab Jan 11, 2022

greg-1-anderson left a comment

CdrMarks commented Feb 15, 2022

[CMS-459] Add php 8.1 support #2295

[CMS-459] Add php 8.1 support #2295

Conversation

jabxjab commented Dec 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg-1-anderson left a comment

Choose a reason for hiding this comment

uberhacker commented Dec 24, 2021

greg-1-anderson commented Jan 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg-1-anderson left a comment

Choose a reason for hiding this comment

CdrMarks commented Feb 15, 2022