Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMS-459] Add php 8.1 support #2284

Merged
merged 10 commits into from
Dec 17, 2021
Merged

[CMS-459] Add php 8.1 support #2284

merged 10 commits into from
Dec 17, 2021

Conversation

jabxjab
Copy link
Contributor

@jabxjab jabxjab commented Dec 17, 2021

No description provided.

@jabxjab jabxjab requested a review from a team December 17, 2021 09:09
@jabxjab jabxjab marked this pull request as ready for review December 17, 2021 13:25
exit(1);
}
// Prevent outputting PHP deprecation messages produced by vendors.
error_reporting(error_reporting() & ~E_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can go with the pragmatic solution. We should still fix our dependencies and remove this as follow-on work.

@greg-1-anderson greg-1-anderson merged commit 6584f0a into 3.x Dec 17, 2021
@greg-1-anderson greg-1-anderson deleted the feature/cms-459 branch December 17, 2021 14:31
greg-1-anderson added a commit that referenced this pull request Dec 18, 2021
greg-1-anderson added a commit that referenced this pull request Dec 18, 2021
* Revert "[CMS-459] Add php 8.1 support (#2284)"

This reverts commit 6584f0a.

* Run tests on PHP 7.4 as well
greg-1-anderson added a commit that referenced this pull request Jan 5, 2022
* Revert "[CMS-459] Add php 8.1 support (#2284)"

This reverts commit 6584f0a.

* Run tests on PHP 7.4 as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants