[OTTO-161] Support directories in --to option for backup:get #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaDethray
suggested changes
Jan 28, 2020
There was a problem hiding this comment.
This is perfect. Please add a couple of lines to CHANGELOG.md which mentions this. Something like:
### Changed
- `Request::download($url, $target)` now accepts directories in addition to files as its `$target` parameter. (#2053)
- The `backup:get` command's `--to` option now accepts directories in addition to files. (#2053)
| @@ -56,6 +56,14 @@ class Request implements ConfigAwareInterface, ContainerAwareInterface, LoggerAw | |||
| */ | |||
There was a problem hiding this comment.
Can line 54 be updated to mention that you can use a directory now? (Something like "Target file or directory's name")
TeslaDethray
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1627