[AL-1742] Apply filter-via-dot-access-data to RowsOfFields-returning commands #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaDethray
suggested changes
Jul 19, 2019
CHANGELOG.md
Outdated
| @@ -91,7 +91,24 @@ All notable changes to this project will be documented in this file. This projec | |||
| - Added `is_owner` field to the output of `site:team:list` in order to indicate which user is the site owner. (#1949) | |||
| - Added boolean `is_owner` field to the output of `SiteUserMemberships::serialize()` in order to indicate which user is the site owner. (#1949) | |||
| - Added `SiteUserMemberships::isOwner()` function in order to ascertain whether the user is the site's owner. (#1949) | |||
| - A `--progress` option has been added to `remote:drush` and `remote:wp` to enable progress for remote commands. (#1947) | |||
| - A `--progress` option has been added to `remote:drush` and `remote:wp` to enable progress for remote commands. (#1947)\- Added --filter option to `backup:list` command (#1992) | |||
There was a problem hiding this comment.
A line break got swapped with a \ here
CHANGELOG.md
Outdated
| @@ -138,6 +155,12 @@ All notable changes to this project will be documented in this file. This projec | |||
| ### Deprecated | |||
| - `service-level:set` is now deprecated. Please use `plan:set`. (#1901) | |||
| - `Site::updateServiceLevel()` is now deprecated. Please use `Plans::set()`. (#1901) | |||
| - `backup:list` `--element=VALUE` option is deprecated. Use `--filter="type=VALUE"` instead. (#1992) | |||
| - `org:upstream:list` `--framework=VALUE` options is deprecated. Use `--filter="id=VALUE" instead. (#1992) | |||
There was a problem hiding this comment.
Needs a ` after VALUE"
There was a problem hiding this comment.
The filter key is framework instead of id.
CHANGELOG.md
Outdated
| @@ -138,6 +155,12 @@ All notable changes to this project will be documented in this file. This projec | |||
| ### Deprecated | |||
| - `service-level:set` is now deprecated. Please use `plan:set`. (#1901) | |||
| - `Site::updateServiceLevel()` is now deprecated. Please use `Plans::set()`. (#1901) | |||
| - `backup:list` `--element=VALUE` option is deprecated. Use `--filter="type=VALUE"` instead. (#1992) | |||
| - `org:upstream:list` `--framework=VALUE` options is deprecated. Use `--filter="id=VALUE" instead. (#1992) | |||
| - `org:upstream:list` `--name=VALUE` option is deprecated. Use `--filter="id=VALUE" instead. (#1992) | |||
There was a problem hiding this comment.
The filter key is label instead of id
CHANGELOG.md
Outdated
| - `backup:list` `--element=VALUE` option is deprecated. Use `--filter="type=VALUE"` instead. (#1992) | ||
| - `org:upstream:list` `--framework=VALUE` options is deprecated. Use `--filter="id=VALUE" instead. (#1992) | ||
| - `org:upstream:list` `--name=VALUE` option is deprecated. Use `--filter="id=VALUE" instead. (#1992) | ||
| - `site:list` `--name=VALUE` option is deprecated. Use `--filter="id=VALUE" instead.(#1992) |
There was a problem hiding this comment.
The filter key is name instead of id
There was a problem hiding this comment.
Needs a ` after VALUE"
CHANGELOG.md
Outdated
| - `org:upstream:list` `--framework=VALUE` options is deprecated. Use `--filter="id=VALUE" instead. (#1992) | ||
| - `org:upstream:list` `--name=VALUE` option is deprecated. Use `--filter="id=VALUE" instead. (#1992) | ||
| - `site:list` `--name=VALUE` option is deprecated. Use `--filter="id=VALUE" instead.(#1992) | ||
| - `site:list` `--plan=VALUE` option is deprecated. Use `--filter="plan_name=VALUE" instead.(#1992) |
There was a problem hiding this comment.
Needs a ` after VALUE"
src/Commands/Env/CodeLogCommand.php
Outdated
| @@ -19,6 +19,7 @@ class CodeLogCommand extends TerminusCommand implements SiteAwareInterface | |||
| * Displays the code log for the environment. | |||
| * | |||
| * @authorize | |||
| * | |||
There was a problem hiding this comment.
A line got added here
| @@ -21,6 +21,7 @@ class ListCommand extends TerminusCommand implements SiteAwareInterface | |||
| * Displays the list of sites associated with an organization. | |||
| * | |||
| * @authorize | |||
| * @filter-output | |||
| * | |||
| * @command org:site:list | |||
| * @aliases org:sites | |||
There was a problem hiding this comment.
This command has filters to deprecate.
src/Commands/Tag/ListCommand.php
Outdated
| @@ -14,6 +14,7 @@ class ListCommand extends TagCommand | |||
| * Displays the list of tags for a site within an organization. | |||
| * | |||
| * @authorize | |||
| * | |||
There was a problem hiding this comment.
A line got added here
| @@ -18,6 +18,7 @@ class ListCommand extends TerminusCommand | |||
| * Displays the list of upstreams accessible to the currently logged-in user. | |||
| * | |||
| * @authorize | |||
| * @filter-output | |||
| * | |||
| * @command upstream:list | |||
| * @aliases upstreams | |||
There was a problem hiding this comment.
This command has filters to deprecate.
| @@ -187,6 +187,7 @@ public function serialize() | |||
| 'expiry' => $this->getExpiry(), | |||
| 'initiator' => $this->getInitiator(), | |||
| 'url' => $this->get('archive_url'), | |||
| 'type' => $this->get('type'), | |||
There was a problem hiding this comment.
We'll want to make sure this gets covered in unit testing. We'll look at this together.
|
I've just realized that I didn't explain where in the CHANGELOG.md file to add the lines. 😓We'll move them and I'll explain it when we look at this together. |
|
Good job on putting up this PR! Maybe add the JIRA ticket number AL-1742 to this PR's title? So it is connected to your JIRA ticket~ |
oubawaleh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.