Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-1612 - Added an initialization check to env:clone-content for the target environment in order to prevent workflow error #1930

Merged
merged 5 commits into from
Jan 22, 2019

Conversation

TeslaDethray
Copy link
Contributor

No description provided.

{
if (!$env->isInitialized()) {
throw new TerminusException(
"{site}'s {env} environment cannot be cloned because it has not been initialized. Please run `env:deploy {site}.{env}` to initialize it.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this language is too specific since the check is used for both the source and the destination?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I think I do want to change this.

Copy link
Contributor

@ronan ronan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor language question. Otherwise lgtg

@TeslaDethray TeslaDethray merged commit 5f7cd45 into master Jan 22, 2019
@TeslaDethray TeslaDethray deleted the al-1612 branch January 22, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants