-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipped TerminusCollection; defaults to fetchless; added APICollection #1779
Conversation
69dfe7b
to
0ecbbe4
Compare
0ecbbe4
to
df560aa
Compare
3e642c5
to
3946354
Compare
2b19e3c
to
179c07e
Compare
179c07e
to
a1eb69f
Compare
e2874bc
to
f074f57
Compare
f074f57
to
b35cfa9
Compare
$tokens = []; | ||
foreach ($this->getDataStore()->keys() as $key) { | ||
$tokens[] = (object)$this->getDataStore()->get($key); | ||
if (empty(parent::getData())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggering my php alarms, but I guess it's no longer a problem since we don't support older versions of php. Old instincts die hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I was using $this->data
, but then I fought it: "Do you want to change every instance of it if you start doing something else with the data?" While I couldn't decide what might change, I figured I ought to encapsulate against the future anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 👌 👌 +1
This changes how TerminusCollection works in these ways:
Other changes: