Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1739: (Workaround) Pin the version of reflection-docblock #1740

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Jul 17, 2017

A new version of the reflection-docblock project was released, introducing strict syntax-checking on the @Usage tag. @Usage is not documented in the phpdocumentor documentation at the time of this writing. Presumably, this is a new addition.

This is a short-term fix to allow CI builds using Terminus to work again.

Longer-term fixes:

  1. Perhaps the Terminus installer should fetch the Terminus composer.lock file and then install via composer install, so that the tested dependencies are always used. Installing via composer create-project also respects composer.lock files.

  2. The annotated command library should probably use a bespoke docblock comment parser to avoid problems with changing definitions of the parent library

@greg-1-anderson
Copy link
Member Author

Short-term recommendation: Assuming tests pass, merge this and tag a stable release so that CI scripts will start working again.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.199% when pulling 2522c6b on pin-reflection-docblock into deb495a on master.

Copy link

@arosboro arosboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes my CI build. I changed line 46 of circle.yml to cgr "pantheon-systems/terminus:dev-pin-reflection-docblock" to perform the review.

@dearmond
Copy link

This branch fixed the CI issues for me. I did as @arosboro recommended. Worked great!

@rbayliss
Copy link

Just chiming in here to say that the temporary fix works for us as well. Thank you! Is there any possibility of getting a PHAR version of terminus primarily for use in CI? Seems like that would solve this issue pretty easily.

Copy link
Contributor

@ronan ronan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@greg-1-anderson greg-1-anderson merged commit 4058d59 into master Jul 17, 2017
@TeslaDethray TeslaDethray deleted the pin-reflection-docblock branch February 20, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants