AL-885, AL-911 - Added backup:info command, expiry to backup:list #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaDethray
force-pushed
the
addition/backup_get
branch
2 times, most recently
from
6acd943
to
7459d16
Compare
TeslaDethray
force-pushed
the
addition/backup_get
branch
from
7459d16
to
24dc0a3
Compare
ronan
reviewed
Apr 4, 2017
| @@ -22,6 +22,7 @@ class ListCommand extends BackupCommand | |||
| * file: Filename | |||
| * size: Size | |||
| * date: Date | |||
| * expiry: Expiry | |||
There was a problem hiding this comment.
While I personally like this, I believe US english prefers 'expiration'. But I'm 1/10 on this because expiry is shorter and way classier because it is true uncorrupted queens english :)
There was a problem hiding this comment.
I like it too, so let's ask @kimby77 to weigh in. What do you think?
|
Unable to actually test because of |
TeslaDethray
force-pushed
the
addition/backup_get
branch
from
7cd1a82
to
bd18054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1668
Closes #1643