Update to fix upcoming changes in Robo. #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
force-pushed
the
robo-update
branch
from
121cea2
to
5d4fb47
Compare
|
Robo 1.0.6 has been tagged; this means that anyone who has a project that requires Terminus as a dependency is failing until this PR is merged. |
|
Workaround: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Robo is enhancing its configuration features in consolidation/robo#552.
I started a PR to rework Terminus configuration to use the Robo
ConfigProcessorclass to load Terminus' configuration, and got far enough to be confident that doing this would not present any problems, if the new features are desired in Terminus.This is not necessary, though; this PR demonstrates that the existing Terminus configuration classes can continue to work with the updated Robo. A few minor changes are needed to Terminus at places where it touches Robo internals; see diff for details.
A couple Terminus tests fail, because they use mocks to make assertions about the internal behavior of Robo, which changes with #552. It would be great if someone could do me the favor of updating those at some point.
This PR should not be merged until #552 is merged, and Robo 1.1.0 is tagged.