New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch New Relic info before trying to print it. #1629

Closed

rvtraveller wants to merge 1 commit into pantheon-systems:master from rvtraveller:new-relic-info-fix

rvtraveller commented Feb 25, 2017

Fixes #1626


          Fetch New Relic info before trying to print it.

ee93563

Contributor

TeslaDethray commented Feb 27, 2017

@rvtraveller This is a good change, but the tests need to be updated to mock a fetch() call.

You'll need to set the Request object to mock it like is done here:
https://github.com/pantheon-systems/terminus/blob/master/tests/unit_tests/Models/SiteTest.php#L130
Then you'll need to make it ready for the call, like here:
https://github.com/pantheon-systems/terminus/blob/master/tests/unit_tests/Models/SiteTest.php#L240-L243

I can do this for you, but that would mean your PR doesn't get merged.

Author

rvtraveller commented Mar 1, 2017

Thanks @TeslaDethray! I'll work on updating the tests. Appreciate the pointers.

TeslaDethray mentioned this pull request

Fetch NewRelic info before outputting it #1648

Merged

Contributor

TeslaDethray commented Mar 8, 2017

Superseded by #1648

TeslaDethray closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet