Changed self:cc to remove cached command files #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaDethray
force-pushed
the
fix/self_cc
branch
from
28a79ee
to
5523283
Compare
| } | ||
|
|
||
| /** | ||
| /** |
There was a problem hiding this comment.
Typo - double open-comend
TeslaDethray
force-pushed
the
fix/self_cc
branch
from
5523283
to
cc72ca3
Compare
|
Looks good to me -- just noticed one minor typo |
TeslaDethray
force-pushed
the
fix/self_cc
branch
3 times, most recently
from
385aabe
to
624811a
Compare
| { | ||
| use ConfigAwareTrait; |
There was a problem hiding this comment.
TerminusCommand already uses ConfigAwareTrait. php7 doesn't mind the re-use, but 5.6 and 5.5 don't like it, ergo the test failures.
TeslaDethray
force-pushed
the
fix/self_cc
branch
from
624811a
to
b8dadd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1567