Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGS-976- Removed framework check from remote type commands #1521

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

TeslaDethray
Copy link
Contributor

No description provided.

@pantheon-mentionbot
Copy link

@TeslaDethray, thanks for your PR! By analyzing the blame information on this pull request, we identified @ajbarry, @greg-1-anderson and @bensheldon to be potential reviewers

@TeslaDethray TeslaDethray changed the title AL-976- Removed framework check from remote-type commands BUGS-976- Removed framework check from remote-type commands Jan 11, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 81.864% when pulling 88b59e1 on remove/ssh_framework_check into de4e1f4 on master.

@ajbarry
Copy link
Contributor

ajbarry commented Jan 11, 2017

@TeslaDethray I thought we agreed that this was a good addition at the time I committed it why the change of ❤️

@TeslaDethray TeslaDethray changed the title BUGS-976- Removed framework check from remote-type commands BUGS-976- Removed framework check from remote type commands Jan 11, 2017
@ronan
Copy link
Contributor

ronan commented Jan 11, 2017

@ajbarry: More background in the Jira card: https://getpantheon.atlassian.net/browse/BUGS-976

@TeslaDethray: +1

@greg-1-anderson
Copy link
Member

I should mention that what the endpoint cookbook does is:

If framework is wordpress or wordpress-network, then install wp-cli.

If framework is NOT wordpress or wordpress-network, then install drush.

I think it's fine to just remove the checks, though.

@greg-1-anderson
Copy link
Member

n.b. part two: It is a goal in platfrastructure to remove framework in favor of pantheon.yml control, so removing references to it is probably best. That way, we don't have to maintain framework just to keep Terminus working.

+1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 82.81% when pulling 68ebba6 on remove/ssh_framework_check into 44f2b73 on master.

@TeslaDethray TeslaDethray merged commit 6ffba3d into master Jan 11, 2017
@TeslaDethray TeslaDethray deleted the remove/ssh_framework_check branch January 11, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants