Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error by adding back use statement for ProcessUtils #1494

Merged

Conversation

stevector
Copy link
Contributor

@greg-1-anderson, @TeslaDethray These two PRs were being worked on at the same time and somehow the use statement added in #1484 was removed in #1480. The actual invocation of class remained.

I saw an error in a script that wasn't yet using the argument separator https://circleci.com/gh/pantheon-systems/search_api_pantheon/561

The error was triggered by terminus drush $SITE_ENV "pm-uninstall search -y" (which of course needed to change anway to terminus drush $SITE_ENV -- pm-uninstall search -y).

@pantheon-mentionbot
Copy link

@stevector, thanks for your PR! By analyzing the blame information on this pull request, we identified @ajbarry, @TeslaDethray and @greg-1-anderson to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.981% when pulling 8d077be on stevector:processUtils-use-statement into 9e92add on pantheon-systems:master.

Copy link
Contributor

@ajbarry ajbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh. Thanks @stevector!

@TeslaDethray TeslaDethray merged commit a7e3856 into pantheon-systems:master Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants