[AL-587] Adding env:commit and env:code-log commands #1250

marktheunissen · 2016-09-26T13:48:19Z

No description provided.

pantheon-mentionbot · 2016-09-26T13:48:22Z

@marktheunissen, thanks for your PR! By analyzing the blame information on this pull request, we identified @TeslaDethray and @ronan to be potential reviewers

marktheunissen · 2016-09-26T13:51:46Z

src/Commands/Env/CommitCommand.php

+        $env  = $site->environments->get($env_name);
+
+        // TODO: The 0.x command would prompt if there were no changed files, asking
+        //   if the user wanted to commit anyway.


@ari-gold What is the desired behavior if there is nothing to commit?

I can't tell why the 0.x command prompts in this way. For now, let's just go with:

"[warning] There is no code to commit on <site.env>."
or
"[warning] There is no code to commit."

like

."

@ari-gold done

aleszoulek · 2016-09-26T13:57:15Z

src/Commands/Env/CodeLogCommand.php

+                    str_replace(
+                        "\n",
+                        '',
+                        str_replace("\t", '', substr($log->get('message'), 0, 50))


str_replace(array("\n", "\t"), '' ...) could also work?

Yeah maybe I just copied it from the old code... :) We're porting the 0.x commands to 1.0

coveralls · 2016-09-26T18:06:41Z

Coverage remained the same at 22.972% when pulling e2579e3 on env_commit_and_log into cf0b87d on master.

coveralls · 2016-09-27T07:40:05Z

Coverage remained the same at 22.972% when pulling 73869cb on env_commit_and_log into 30715ec on master.

marktheunissen · 2016-09-27T08:05:47Z

src/Commands/Env/DeployCommand.php

@@ -31,7 +32,6 @@ public function deploy($site_env, $options = [
                                    'cc' => false,
                                    'updatedb' => false,])
    {
-        // @TODO: Switch this to the standard site.env input format?


@ronan I don't follow this comment - are you saying this is this not the standard site.env format?

coveralls · 2016-09-27T08:42:31Z

Coverage remained the same at 22.972% when pulling 44de42b on env_commit_and_log into 30715ec on master.

TeslaDethray

The messy str_replace that @aleszoulek would be worth tidying up, but this looks good!

TeslaDethray · 2016-09-27T19:55:31Z

src/Commands/Env/CodeLogCommand.php

+     *
+     * @command env:code-log
+     *
+     * @param string $site_env Site & environment to show log for.


I've just noticed that there aren't any labels on the fields. Please add some. Here's the syntax for quick reference:
https://github.com/pantheon-systems/terminus/blob/master/src/Commands/Upstream/UpdatesListCommand.php#L20-L26

Will do, thanks!

coveralls · 2016-09-30T09:45:47Z

Coverage remained the same at 23.539% when pulling 2f4c31c on env_commit_and_log into 80620b8 on master.

coveralls · 2016-09-30T10:19:36Z

Coverage remained the same at 23.539% when pulling 9ecf529 on env_commit_and_log into 80620b8 on master.

coveralls · 2016-10-01T07:43:06Z

Coverage remained the same at 23.557% when pulling bbb31e1 on env_commit_and_log into 07937db on master.

coveralls · 2016-10-01T07:43:06Z

Coverage remained the same at 23.557% when pulling bbb31e1 on env_commit_and_log into 07937db on master.

marktheunissen force-pushed the env_commit_and_log branch from be8b05c to 85b86e1 Compare September 26, 2016 13:50

marktheunissen changed the title ~~Adding env:commit and env:code-log commands~~ [AL-587] Adding env:commit and env:code-log commands Sep 26, 2016

marktheunissen commented Sep 26, 2016

View reviewed changes

aleszoulek reviewed Sep 26, 2016

View reviewed changes

marktheunissen self-assigned this Sep 26, 2016

marktheunissen force-pushed the env_commit_and_log branch 2 times, most recently from 514ae24 to e2579e3 Compare September 26, 2016 17:53

marktheunissen force-pushed the env_commit_and_log branch from e2579e3 to 73869cb Compare September 27, 2016 07:26

marktheunissen commented Sep 27, 2016

View reviewed changes

marktheunissen force-pushed the env_commit_and_log branch from 73869cb to 44de42b Compare September 27, 2016 08:25

TeslaDethray added the Ready to Ship label Sep 27, 2016

TeslaDethray approved these changes Sep 27, 2016

View reviewed changes

TeslaDethray suggested changes Sep 27, 2016

View reviewed changes

TeslaDethray added Changes Requested and removed Ready to Ship labels Sep 27, 2016

marktheunissen force-pushed the env_commit_and_log branch 2 times, most recently from 44de42b to 2f4c31c Compare September 30, 2016 09:34

marktheunissen force-pushed the env_commit_and_log branch from 2f4c31c to 253f665 Compare September 30, 2016 09:58

marktheunissen added Needs Review and removed Changes Requested labels Sep 30, 2016

Adding env:commit and env:code-log commands

9ecf529

marktheunissen force-pushed the env_commit_and_log branch from 253f665 to 9ecf529 Compare September 30, 2016 10:08

TeslaDethray added Ready to Ship and removed Needs Review labels Sep 30, 2016

TeslaDethray approved these changes Sep 30, 2016

View reviewed changes

Merge branch 'master' into env_commit_and_log

bbb31e1

marktheunissen merged commit 952fa66 into master Oct 1, 2016

marktheunissen deleted the env_commit_and_log branch October 1, 2016 07:43

violinist-bot mentioned this pull request Feb 11, 2020

Update behat/behat from v3.5.0 to v3.6.1 SignWo/terminus#126

Open

violinist-bot mentioned this pull request Jun 5, 2020

Update behat/behat from v3.5.0 to v3.7.0 SignWo/terminus#147

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AL-587] Adding env:commit and env:code-log commands #1250

[AL-587] Adding env:commit and env:code-log commands #1250

marktheunissen commented Sep 26, 2016

pantheon-mentionbot commented Sep 26, 2016

marktheunissen Sep 26, 2016

ari-gold Sep 29, 2016

marktheunissen Sep 30, 2016

marktheunissen Sep 30, 2016

aleszoulek Sep 26, 2016

marktheunissen Sep 26, 2016

coveralls commented Sep 26, 2016 •

edited

Loading

coveralls commented Sep 27, 2016 •

edited

Loading

marktheunissen Sep 27, 2016

coveralls commented Sep 27, 2016 •

edited

Loading

TeslaDethray left a comment

TeslaDethray Sep 27, 2016 •

edited

Loading

marktheunissen Sep 30, 2016

coveralls commented Sep 30, 2016 •

edited

Loading

coveralls commented Sep 30, 2016 •

edited

Loading

coveralls commented Oct 1, 2016

coveralls commented Oct 1, 2016 •

edited

Loading

[AL-587] Adding env:commit and env:code-log commands #1250

[AL-587] Adding env:commit and env:code-log commands #1250

Conversation

marktheunissen commented Sep 26, 2016

pantheon-mentionbot commented Sep 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 26, 2016 • edited Loading

coveralls commented Sep 27, 2016 • edited Loading

Choose a reason for hiding this comment

coveralls commented Sep 27, 2016 • edited Loading

TeslaDethray left a comment

Choose a reason for hiding this comment

TeslaDethray Sep 27, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 30, 2016 • edited Loading

coveralls commented Sep 30, 2016 • edited Loading

coveralls commented Oct 1, 2016

coveralls commented Oct 1, 2016 • edited Loading

coveralls commented Sep 26, 2016 •

edited

Loading

coveralls commented Sep 27, 2016 •

edited

Loading

coveralls commented Sep 27, 2016 •

edited

Loading

TeslaDethray Sep 27, 2016 •

edited

Loading

coveralls commented Sep 30, 2016 •

edited

Loading

coveralls commented Sep 30, 2016 •

edited

Loading

coveralls commented Oct 1, 2016 •

edited

Loading