Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frozen state to site name #1015

Merged
merged 3 commits into from
Apr 6, 2016
Merged

Add frozen state to site name #1015

merged 3 commits into from
Apr 6, 2016

Conversation

kibra
Copy link
Contributor

@kibra kibra commented Apr 1, 2016

No description provided.

@TeslaDethray
Copy link
Contributor

I don't think that the frozen state should be added to the name, but as its own column. We could also filter for --frozen.

@kibra
Copy link
Contributor Author

kibra commented Apr 1, 2016

@TeslaDethray I thought about that, but most users won't have a frozen site at all, so I didn't want to add another column when most people won't ever see the attribute as true.

Could we only add the column if any site is frozen?

@TeslaDethray
Copy link
Contributor

@kibra I don't think it will do good to have the fields changing because people scripting with Terminus depend on its consistency. The frozen column should always be present if it is to be present at all, and not in the name. Consistency is paramount.

@TeslaDethray
Copy link
Contributor

...that is, unless the point is to break the script so the site owner has to deal with the site. Hmm.

@kibra kibra force-pushed the frozen_state_in_sites_list branch from 2711b10 to 7df8e74 Compare April 4, 2016 17:45
@TeslaDethray
Copy link
Contributor

@kibra Can I ask you to add a CHANGELOG entry for the change too, please? Other than that, LGTM.

@TeslaDethray
Copy link
Contributor

@kibra I went ahead and added the changelog addition. Good to go! Do you need me to cut a release for this immediately upon merge?

@kibra
Copy link
Contributor Author

kibra commented Apr 6, 2016

@TeslaDethray Thank you for the changelog update! Re. cutting a release, I don't think that's necessary. Whenever the next cut happens is perfectly fine.

@kibra kibra merged commit 5f56e84 into master Apr 6, 2016
@TeslaDethray TeslaDethray deleted the frozen_state_in_sites_list branch April 6, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants