-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frozen state to site name #1015
Conversation
d73d3fd
to
2711b10
Compare
I don't think that the frozen state should be added to the name, but as its own column. We could also filter for |
@TeslaDethray I thought about that, but most users won't have a frozen site at all, so I didn't want to add another column when most people won't ever see the attribute as true. Could we only add the column if any site is frozen? |
@kibra I don't think it will do good to have the fields changing because people scripting with Terminus depend on its consistency. The frozen column should always be present if it is to be present at all, and not in the name. Consistency is paramount. |
...that is, unless the point is to break the script so the site owner has to deal with the site. Hmm. |
2711b10
to
7df8e74
Compare
7df8e74
to
38da413
Compare
@kibra Can I ask you to add a CHANGELOG entry for the change too, please? Other than that, LGTM. |
a51865b
to
b59b7c2
Compare
@kibra I went ahead and added the changelog addition. Good to go! Do you need me to cut a release for this immediately upon merge? |
@TeslaDethray Thank you for the changelog update! Re. cutting a release, I don't think that's necessary. Whenever the next cut happens is perfectly fine. |
No description provided.