Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Drush Command for posting solr schema #99

Closed

Conversation

stevector
Copy link

Fulfills #82

@greg-1-anderson, I'm going to schedule a meeting for tomorrow for us to discuss how to test this functionality and other parts of the repo.

@amitaibu
Copy link

Hi @stevector !

Will this go in at a certain point, or should we for now create our own custom script that basically does the same?

@stevector
Copy link
Author

@amitaibu! I think this PR could still eventually get merged. It would have to be tested and approved to then be released with a regular core release. (We try to limit the number of releases that come through the Pantheon dashboard) I saw you were chatting with @greg-1-anderson over in pantheon-systems/quicksilver-examples#142. Does that get the job done for you?

@amitaibu
Copy link

@stevector !! 😄

pantheon-systems/quicksilver-examples#142 is actually another issue from Gizra, but not I was working on (thus, I don't care about it that much 😜), but I'll have to try it at a certain point.

This PR however seems to do the job for me - I'm now using it for a site creation script, where Solr is also configured.

@stevector stevector changed the title WIP - Adding Drush Command for posting solr schema Adding Drush Command for posting solr schema Oct 29, 2018
@stevector
Copy link
Author

Glad to know it is working for you! @greg-1-anderson, what do you think of merging this into a future release?

@greg-1-anderson
Copy link
Member

Hm there's a release of Drupal 7 due out this Wednesday...

@greg-1-anderson
Copy link
Member

Could you make this PR merge into the default branch @stevector ?

@greg-1-anderson
Copy link
Member

... and rebase it off of HEAD of default?

@stevector
Copy link
Author

Done! #131

@stevector stevector closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants