Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Ignore keyPrefix property if namespace prefix used #8

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

lexxor
Copy link
Contributor

@lexxor lexxor commented Oct 4, 2017

Hi!

keyPrefix property should be ignored if key with namespace prefix used. Something like $t('common:cancel')

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.347% when pulling d48ac47 on lexxor:ignore-key-prefix-if-namespace into d7f7dae on panter:master.

@claudiocro
Copy link
Member

Thank you very much!

In this project we use semantic-release. Can you rephrase your commit message to fix: Ignore keyPrefix property if namespace prefix used?

FYI: commit message format

Thx!

@lexxor lexxor changed the title Ignore keyPrefix property if namespace prefix used fix: Ignore keyPrefix property if namespace prefix used Oct 17, 2017
@lexxor lexxor changed the title fix: Ignore keyPrefix property if namespace prefix used Ignore keyPrefix property if namespace prefix used Oct 17, 2017
@lexxor lexxor force-pushed the ignore-key-prefix-if-namespace branch from d48ac47 to 783aed9 Compare October 17, 2017 05:31
@lexxor
Copy link
Contributor Author

lexxor commented Oct 17, 2017

@claudiocro done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.347% when pulling 783aed9 on lexxor:ignore-key-prefix-if-namespace into d7f7dae on panter:master.

@claudiocro claudiocro merged commit aee90dc into panter:master Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants