Individual tokens #22
Conversation
| @@ -141,50 +138,52 @@ FacebookInsightStream.prototype._init = function ( callback ) { | |||
| } | |||
|
|
|||
| FacebookInsightStream.prototype._initItem = function ( item ) { | |||
| var id = typeof item === 'string' ? item : item.id | |||
There was a problem hiding this comment.
null will give you an object - just make sure theres no possibility for nulls in the input or take care of this end
There was a problem hiding this comment.
If somehow a page object arrives in the source as NULL there is not much we can do at this stage. I don't want to start filtering out nulls that should be page objects since as soon as we do that we can't consider the job as a success. The items themselves originate from Facebook so I don't see any way to recover from being passed nulls - it will simply fail as soon as we try to access the id attribute.
| * @param {String} url | ||
| * @returns {Promise} | ||
| */ | ||
| FacebookInsightStream._apiCall = function (url) { |
There was a problem hiding this comment.
we use underscore for internal functions only no?..
There was a problem hiding this comment.
This is used as an internal function, yes - it shouldn't be used outside of the module.
These changes allow for the stream to use a separate access_token for each entity.
Previously, only one user access token was used but after this PR, each facebook entity is passed as an object and includes it's specific access token.