Fetch facebook data from BOT #20
Conversation
…nd by so bring data from BOT
There was a problem hiding this comment.
@hadasiii I have no problem with the changes as they simply omit undefined properties from the request string which is great. But I am not sure I understand what is this BOT, What does it mean fetching data from BOT?
It also should be explained in the README file of this repo. (NOTE that it is public).
I am rejecting because of the testing, I am not sure what you are testing. And I don't think that relying on the stream.url in the test is a good idea, it is fragile. You can use the URL argument from the call to request.getAsync.
test.js
Outdated
| before( initialize( result, response, source, true ) ) | ||
| after( reset ) | ||
|
|
||
| it( 'Skip missing data', function () { |
There was a problem hiding this comment.
I am not sure what are you testing here and what it has to do with missing data?
test.js
Outdated
| before( initialize( result, response, source ) ) | ||
| after( reset ) | ||
|
|
||
| it( 'Skip missing data', function () { |
There was a problem hiding this comment.
Same here, What are you testing?
|
@oshribin |
Updated the stream to not include since when pastdays is undefined,
by so fetching data from BOT.
This is needed for godaddy custom solution.