Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Section & Snippets Autocomplete not working when using config.method = workspace #162

Closed
muchisx opened this issue Jul 22, 2023 · 4 comments
Closed

[4.0] Section & Snippets Autocomplete not working when using config.method = workspace #162

muchisx opened this issue Jul 22, 2023 · 4 comments
Labels
Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release

Comments

@muchisx
Copy link
Collaborator

muchisx commented Jul 22, 2023

Hi, basically the title.
I am using the latest vsix file in the next branch.

All of the tests can be found in my Tests Repo for Liquify for easy replicating
https://github.com/muchisx/Liquify-Shopify-test-bench

Recording.2023-07-22.161203.mp4
@panoply
Copy link
Owner

panoply commented Jul 23, 2023

Following our chat in discord. Still haven't got around to this, will try tackle tonight. Folks have been waiting for 4.0 for far too long. Need to get some ground work applied here and supporting workspace settings is very much imperative, especially for cases like you were you are constantly switching between projects and the .liquidrc is a hassle.

I'll notify when patched.

@panoply panoply added Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release labels Jul 23, 2023
@muchisx
Copy link
Collaborator Author

muchisx commented Jul 23, 2023

Sounds good!
I think it can benefit all of those that work for many projects in a day and prefer a global config for all of them.

@muchisx muchisx closed this as completed Jul 23, 2023
@panoply panoply reopened this Jul 23, 2023
@panoply
Copy link
Owner

panoply commented Jul 23, 2023

Still not done on this. Will keep open for now.

panoply added a commit that referenced this issue Jul 24, 2023
@panoply
minor improvements to log output grammars
25ec33b 
#162 Related
panoply added a commit that referenced this issue Jul 24, 2023
@panoply
Fixes #162
22584c9
@panoply panoply closed this as completed Jul 24, 2023
@panoply
Copy link
Owner

panoply commented Jul 24, 2023

Patched in 22584c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working in the vscode extension 🚢 Shipping Next Release This issue has been completed and will be available next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panoply @muchisx