Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import asset breaking JS syntax hightlighting #140

Closed
davidwarrington opened this issue Dec 22, 2022 · 2 comments
Closed

import asset breaking JS syntax hightlighting #140

davidwarrington opened this issue Dec 22, 2022 · 2 comments
Labels
Bug Something isn't working in the vscode extension

Comments

@davidwarrington
Copy link
Collaborator

I'm having to write an inline script and the import syntax combined with a Liquid tag has broken highlighting

It seems full imports specifically that are causing an issue for me

import {{ 'file.js' | asset_url | json }}

image

Replacing the json filter by wrapping the liquid tag in quotes resolved the issue for me, I just prefer to use json if possible because I expect that it's safer (although now I think about it I'm unsure if it is in this context).

image

It's probably not a high priority issue regardless but figured I best report it

@panoply panoply added the Bug Something isn't working in the vscode extension label Dec 22, 2022
@panoply
Copy link
Owner

panoply commented Dec 22, 2022

Good catch. Will have it fixed for #138 - Some works needs to be done on the injection grammars for embedded regions. This is a good opportunity to refine that.

@panoply
Copy link
Owner

panoply commented Dec 23, 2022

@davidwarrington 65cbb28 will fix this. I definitely need more samples of Liquid being is being infused within embedded languages. This was a really great use case scenario.

@panoply panoply closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the vscode extension
Projects
None yet
Development

No branches or pull requests

2 participants