Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter adding whitespace to JS string #133

Closed
davidwarrington opened this issue Dec 13, 2022 · 1 comment
Closed

Formatter adding whitespace to JS string #133

davidwarrington opened this issue Dec 13, 2022 · 1 comment
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic

Comments

@davidwarrington
Copy link
Collaborator

Formatter adds space after Liquid tag inside JS string. I've not made any configuration changes so this is using the default settings.

I have the following code:

<script>
  document.body.style.setProperty('--pg-MobileReassurances-fontSize', '{{ section.settings.font_size }}px');
</script>

After saving it becomes the following and breaks existing CSS because of the whitespace it has introduced:

<script>
  document.body.style.setProperty('--pg-MobileReassurances-fontSize', '{{ section.settings.font_size }} px');
</script>
@panoply panoply added Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic labels Dec 13, 2022
panoply added a commit to panoply/liquify that referenced this issue Dec 25, 2022
@panoply
Copy link
Owner

panoply commented Dec 26, 2022

This one is solved in #138

@panoply panoply closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic
Projects
None yet
Development

No branches or pull requests

2 participants