Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Tested this on the tests folder.
What I managed with this
1) Validate that the root schema is an Array of atleast 2 items (
theme metadata
, and asettings_group
)2) Allow
settings_group
to be repeatable and correctly validated as asettings_group
, benefiting from checks and snippets.3) Validate that there's either
theme_support_url
ortheme_support_email
in the schema (following Shopify's docs).4) A lot of individual validations for
input-settings
types.This should set up the grounds for the settings_schema to be correctly validated,
next up, gotta add more snippets and make sure all info is updated with Shopify Docs