Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify settings_schema fixes #1

Merged
merged 11 commits into from
Jul 26, 2023

Conversation

muchisx
Copy link
Contributor

@muchisx muchisx commented Jul 24, 2023

Hi!
Tested this on the tests folder.
What I managed with this

1) Validate that the root schema is an Array of atleast 2 items (theme metadata, and a settings_group)

2) Allow settings_group to be repeatable and correctly validated as a settings_group, benefiting from checks and snippets.

3) Validate that there's either theme_support_url or theme_support_email in the schema (following Shopify's docs).

4) A lot of individual validations for input-settings types.

This should set up the grounds for the settings_schema to be correctly validated,
next up, gotta add more snippets and make sure all info is updated with Shopify Docs

@panoply
Copy link
Owner

panoply commented Jul 25, 2023

@muchisx can I merge this?

@muchisx
Copy link
Contributor Author

muchisx commented Jul 25, 2023

hey @panoply its technically mergeable (it's functional now) but not complete in terms of there's content still left to be added for settings_schema

@panoply panoply merged commit 1d62abe into panoply:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants