Automatically merge dependabot PRs #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jun 14, 2023
| with: | ||
| github-token: '${{ secrets.GITHUB_TOKEN }}' | ||
| - name: Approve and merge | ||
| # if: ${{steps.metadata.outputs.update-type != 'version-update:semver-major'}} |
There was a problem hiding this comment.
go の versioning でどうなのかあんまわかっていないながら、一応CI入れたし全部マージで良いのかなーとコメントアウトしておきました
There was a problem hiding this comment.
ただ、現状だと go に絞ってないので github actions の更新もオートマージになります
kachick
commented
Jun 14, 2023
| run: gh pr review --approve "$PR_URL" && gh pr merge --auto --squash "$PR_URL" | ||
| env: | ||
| PR_URL: ${{github.event.pull_request.html_url}} | ||
| GITHUB_TOKEN: '${{secrets.GITHUB_TOKEN}}' |
There was a problem hiding this comment.
Suggested change
| GITHUB_TOKEN: '${{secrets.GITHUB_TOKEN}}' | |
| GITHUB_TOKEN: '${{ secrets.PERSONAL_ACCESS_TOKEN }}' |
こうすると、マージ後にもCI/CDが走ってデプロイまでされる筈
自分はあまりPATを使わないか、https://github.com/tibdex/github-app-token でワンショットのトークン生成させる事が多いのだけれど、このリポジトリにはすでに設定があるし良いと思います。
kachick
changed the title
kachick
changed the title
|
記載の通り repository の設定を更新しました！ |
|
🤖 ｻﾞﾏｽ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependabot の PR を auto merge したいということだったので、自分が使ってるやり方のPRを一応出しておきます。
サードパーティのマージアクションとかアプリもあると思うので、他のやり方にするならこのPRは閉じちゃってください。
https://github.com/pankona/pankona.github.com/settings => Allow auto-merge
https://github.com/pankona/pankona.github.com/settings/actions => Allow GitHub Actions to create and approve pull requests
二箇所の設定変更チェックが必要です。(Approve は必須にして無さそうなので、コードから抜いてもいいです)